Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: validate primary / secondary region localities at end of txn #103631

Merged
merged 1 commit into from
May 22, 2023
Merged

release-23.1: sql: validate primary / secondary region localities at end of txn #103631

merged 1 commit into from
May 22, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 18, 2023 •
edited by chengxiong-ruan
Loading

Backport 1/1 commits from #103362 on behalf of @fqazi.

/cc @cockroachdb/release

Previously, if a database was restored with skip_localities, there was no way to modify this database to set the primary region since validation would kick in too early during the statement. This meant fixing the regions in a restored database was impossible if the primary region was no longer valid. To address this, this patch, delays locality validation till the end of the transaction.

Fixes: #103290

Release note (bug fix): SET PRIMARY REGION and SET SECONDARY REGION did not validate transactionally, which could prevent cleaning up removed regions after a restore.

Release justification: low-risk fix that addresses an issue that prevents skip_localities restores from being useful

@fqazi
sql: validate primary / secondary region localities at end of txn
91c13ee 
Previously, if a database was restored with skip_localities,
there was no way to modify this database to set the primary
region since validation would kick in too early during the
statement. This meant fixing the regions in a restored database
was impossible if the primary region was no longer valid. To
address this, this patch, delays locality validation till the
end of the transaction.

Fixes: #103290

Release note (bug fix): SET PRIMARY REGION and SET SECONDARY REGION
did not validate transactionally, which could prevent cleaning up
removed regions after a restore.
@blathers-crl blathers-crl bot requested review from a team as code owners May 18, 2023 21:10
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-103362 branch from cba570b to f9f9ebe Compare May 18, 2023 21:10
@blathers-crl blathers-crl bot requested review from adityamaru and removed request for a team May 18, 2023 21:10
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 18, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-103362 branch from 9ba69fc to 91c13ee Compare May 18, 2023 21:10
@blathers-crl
Copy link
Author

blathers-crl bot commented May 18, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from chengxiong-ruan and fqazi May 18, 2023 21:10
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@chengxiong-ruan chengxiong-ruan merged commit 4ae616d into release-23.1 May 22, 2023
@chengxiong-ruan chengxiong-ruan deleted the blathers/backport-release-23.1-103362 branch May 22, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@adityamaru adityamaru Awaiting requested review from adityamaru adityamaru is a code owner automatically assigned from cockroachdb/disaster-recovery

@fqazi fqazi Awaiting requested review from fqazi

Assignees

@fqazi fqazi

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @chengxiong-ruan @fqazi